Add mge_point_model_from to model_util for compact point-source model…#287
Merged
Add mge_point_model_from to model_util for compact point-source model…#287
Conversation
…ling Adds a new convenience function that constructs a linear MGE Basis of Gaussians whose sigma values span 0.01 arcseconds to 2*pixel_scales, with shared centre and ellipticity priors, suitable for modelling unresolved AGN, nuclear starbursts, or compact unresolved bulge components. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new convenience API in autogalaxy.analysis.model_util to quickly build a compact point-source MGE (linear Gaussian basis) with tied centre/ellipticity priors, plus accompanying unit tests to verify the model structure and prior tying.
Changes:
- Add
mge_point_model_from(pixel_scales, total_gaussians, centre)utility to construct a compact MGE basis suitable for unresolved components. - Fix sigma placement to be logarithmically spaced from 0.01″ to
2 * pixel_scales, with shared centre andell_compspriors across all Gaussians. - Add tests covering component count, sigma endpoints, shared priors, and centre prior bounds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
autogalaxy/analysis/model_util.py |
Adds mge_point_model_from helper to generate a compact linear Gaussian Basis model with tied priors. |
test_autogalaxy/analysis/test_model_util.py |
Adds tests validating the returned model’s structure, sigma range, and shared priors. |
Comments suppressed due to low confidence (1)
test_autogalaxy/analysis/test_model_util.py:3
numpyis imported but never used in this test module; please remove the unused import to keep the test file clean.
import pytest
import numpy as np
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new convenience function that constructs a linear MGE Basis of Gaussians whose sigma values span 0.01 arcseconds to 2*pixel_scales, with shared centre and ellipticity priors, suitable for modelling unresolved AGN, nuclear starbursts, or compact unresolved bulge components.